Use fmpz_init_set_readonly at several places #41295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 7980dbf; changes) is ready! 🎉 |
Contributor
|
I think it is faster than before |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 20, 2025
sagemathgh-41295: Use fmpz_init_set_readonly at several places Supposedly this version does not copy, while the previous one copies the fmpz. Sometimes a temporary variable is needed so that the `Integer` object does not get destroyed (thus destroying the underlying `mpz`) during the time the `fmpz` is used. There are a few other occurrences in other places, as well as `fmpq_init_set_readonly`, but we can start with this. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41295 Reported by: user202729 Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly this version does not copy, while the previous one copies the fmpz.
Sometimes a temporary variable is needed so that the
Integerobject does not get destroyed (thus destroying the underlyingmpz) during the time thefmpzis used.There are a few other occurrences in other places, as well as
fmpq_init_set_readonly, but we can start with this.📝 Checklist
⌛ Dependencies